Files

ramadhan sjamsani a09f37135c Phase 4 checkpoint: chat-screen perf refactor + retryable blast-failure + repo-wide dispose-ref guardrail

Chat-screen performance (customer + mitra):
- Parent screens have zero `ref.watch` — only `ref.listen` for side effects
- Body extracted into its own `ConsumerStatefulWidget`; AppBar parts split
  into narrow `.select` consumers (mode, sensitivity, timer)
- Per-second timer ticks routed to dedicated providers
  (`chatRemainingSecondsProvider` + new `mitraChatRemainingSecondsProvider`)
  so WS `session_tick` frames don't invalidate the rest of the chat state

Dispose-in-ref bug fix:
- `home_screen.dart`, `payment_screen.dart`, `mitra_chat_screen.dart` —
  ref-using cleanup moved from `dispose()` to `deactivate()`. Modern
  Riverpod invalidates `ref` the moment `dispose()` runs; the resulting
  silent error corrupts the widget-tree finalize and the next screen
  appears frozen
- `halo_lints` package added at repo root with `no_ref_in_dispose` rule
  to catch this pattern in CI / IDE analysis
- `custom_lint` activated in both apps' `analysis_options.yaml`
  (was installed but never wired in — also brings `riverpod_lint`'s
  `avoid_ref_inside_state_dispose` online)
- CLAUDE.md Pitfalls section added to client_app + mitra_app

Phase 4 §3 retryable blast-failure (Option A):
- Backend `expirePairingRequest` + all-rejected use
  `recordIntermediateFailure` instead of `failPaymentSession` so the
  payment session stays `confirmed` for re-blast
- WS `pairing_failed` payload carries `is_terminal: false` on the
  retryable paths; client parses the flag and exposes `retryBlast()`
- "Coba cari lagi" CTA on S7 Timeout now re-blasts on the same payment
- Pairing service test updated to reflect the new semantics

Customer waiting-payment screen navigation patch:
- `_navigateTerminal` uses `Future.microtask` + `addPostFrameCallback`
  redundancy after a release-mode bug where polling stopped but
  `context.go` never fired, leaving the screen visually stuck on
  "menunggu pembayaran"

See requirement/resume-2026-05-15.md for next-day pickup checklist
(mitra release rebuild + S21 Ultra install + retest is the gating item).

Bundles unrelated in-flight Phase 4 §2.x work that was already on disk
(ESP screen removal, USP one-time gate scaffolding, bestie-availability
public route, OTP service edits, Maestro flow tweaks) — kept together
to avoid a partial-rebase mess.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

2026-05-14 19:12:34 +08:00

3.1 KiB

Raw Blame History

Halo Bestie — Client App

Flutter mobile application for end users (clients) seeking mental health support.

See root CLAUDE.md for full project context and architectural decisions.

Stack

Framework: Flutter (iOS + Android)
Auth: Self-managed (Phase 3.4). Anonymous-first + phone OTP + (Google / Apple when creds arrive).
- Access token in memory on AuthBridge; refresh token persisted via flutter_secure_storage.
- Google + Apple SDKs installed; buttons are gated server-side via GET /api/shared/auth-providers (cached on cold start in authProvidersProvider). Buttons render only when the corresponding env-driven flag returns enabled: true.
- firebase_auth removed; firebase_messaging kept for FCM push.
API: Calls public Fastify backend (/api/client/ and /api/shared/ routes). Refresh + logout live on shared.auth.
Payment: Xendit (paid sessions, optional trial)

Key Concepts

Users are clients — they seek mental health support ("curhat")
Core flow: server-issued anonymous → optional phone/Google/Apple identity upgrade (same customer row via anonymous_customer_id) → browse/match with mitra → book session → chat → pay
Anonymity toggle: if /api/shared/config/anonymity reports anonymity_enabled = false, the router shows ForceRegisterScreen until the user identifies

Conventions

Never call /api/mitra/ or /internal/ routes from this app
API calls go through ApiClient; it auto-attaches the JWT from AuthBridge and auto-refreshes on 401
WebSocket handshake (/api/shared/ws) reads the access token from AuthBridge in the first frame's {type:"auth", token, session_id?} message
Read authProvidersProvider (core/auth/auth_providers_provider.dart) to gate any Google/Apple UI — never call loginGoogle / loginApple from a path reachable when providers.google / providers.apple is false

Pitfalls (HARD rules — silent failure modes)

Never call `ref.read` / `ref.watch` / `ref.listen` from `State.dispose()`

In a ConsumerStatefulWidget, Riverpod invalidates ref the instant dispose() starts. Any ref.* call throws Bad state: Cannot use "ref" after the widget was disposed.. Flutter catches it inside BuildOwner.finalizeTree — so it does not surface as a red-screen crash. Instead the widget tree is left half-finalized and the NEXT screen freezes (looks like a hang; the app process is alive). Two real cases (2026-05-14): [home_screen.dart] + [payment_screen.dart].

Rule: any cleanup that needs ref goes in deactivate(), which runs before dispose() while ref is still valid. Non-Riverpod cleanup (TextEditingController.dispose(), WidgetsBinding.removeObserver, StreamSubscription.cancel) stays in dispose().

@override
void deactivate() {
  ref.read(someProvider.notifier).cleanup();
  super.deactivate();
}

@override
void dispose() {
  WidgetsBinding.instance.removeObserver(this);
  super.dispose();
}

When debugging "screen frozen after navigation", grep the previous screen's State for void dispose() followed by ref\. — that's the first suspect.

3.1 KiB Raw Blame History