Files
halobestie-clone/backend/test
ramadhan sjamsani a48f108fc0 Phase 4 §2.1: anonymous → existing-user merge breadcrumb
Adds `customers.account_belongs_to UUID NULL` and refactors customer
sign-in (phone/Google/Apple) so an anon row that re-verifies into an
existing customer no longer 409s. Instead the anon row stays intact
with a breadcrumb pointing at the real customer; tokens are issued
for the existing user. Actual data reconciliation onto the existing
row (chat_sessions, customer_transactions, payment_sessions,
pairing_failures) is deferred.

Backend
- migrate.js: ADD COLUMN account_belongs_to UUID REFERENCES customers(id)
  ON DELETE SET NULL.
- customer.service.js: stampAccountBelongsTo helper; account_belongs_to
  exposed in CUSTOMER_SELECT.
- auth.service.js: new shared resolveCustomerForIdentity (4-case logic);
  normalizeIdentityConflict + IDENTITY_ALREADY_LINKED 409 deleted;
  completeCustomerPhoneSignIn / signInWithGoogle / signInWithApple all
  route through the shared helper.
- client.auth.routes.js: new resolveAnonymousCustomerId picks the anon
  prefix ONLY from a verified Bearer JWT — closes the UUID-leak attack
  where a tamper-able body field could mis-route someone else's
  transactions. /otp/verify, /google, /apple all use it; the body field
  `anonymous_customer_id` is no longer accepted on any of them.
- test/services/auth.service.test.js: 9 Vitest cases covering phone +
  Google + Apple, all 4 logic cases + multi-merge accumulation.

Customer app
- auth_notifier.dart::verifyOtp: drop `skipAuth: true` and the dead
  body field so ApiClient auto-attaches the anon's Bearer from
  AuthBridge. Survives the AuthOtpSentData state transition (the
  earlier `_currentAnonymousCustomerId()` state-drop bug is bypassed by
  sourcing the id from the bridge instead of state).
- Google + Apple client paths remain unchanged (gated on provider
  creds; mirror this fix when wiring lands).

Docs
- flow_customer.mermaid.md: new §2.1 sub-section with the merge
  diagram, schema note, replaces-current-behaviour paragraph, and
  Bearer-only security callout.
- phase3.4-testing.md: §1.5 line 76 simplified (no more per-path
  split); new §1.5.1 with the 5-step operator scenario + DB invariants
  + curl recipe + Vitest pointer; new §1.5.2 covering Google/Apple
  parity (deferred client work flagged).

Verification (against live dev backend, before this commit):
- Vitest: 9/9 in auth.service.test.js; 49/51 overall (2 unrelated
  pre-existing failures in session-timer.service.test.js).
- Operator Node smoke: 14/14 in the §1.5.1 scenario; 11/11 in the
  Bearer-precedence cases.
- Real-device UI walkthrough on SM-A530F still pending — see resume
  memory `project_phase4_2_1_resume_test`.

Sister WIP bundled in migrate.js + customer.service.js: `usp_seen`
column + `markCustomerUspSeen` helper (Phase 4 USP one-time gate, was
already uncommitted in the working tree).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-13 23:57:53 +08:00
..

Backend tests (Vitest)

Vitest scaffolding for the Halo Bestie Fastify backend. Three sample tests exist to demonstrate the patterns; broader coverage will be filled in incrementally.

Strategy: schema-isolated remote DB (default)

The remote dev role on omv.sjamsani.id does not have CREATE DATABASE privilege, so the chosen isolation mechanism is a separate schema inside the existing halobestie_clone database. The migration runs into a halobestie_test schema (driven by ?options=-c search_path=... on the test DB URL), leaving the dev public schema untouched.

Valkey isolation uses a separate logical db number (/1) on the same instance.

Why not Docker?

Docker availability could not be verified inside the agent sandbox at scaffold time. A docker-compose.test.yml exists for users who prefer ephemeral local containers — see "Switching to local Docker" below.

Why not a separate Postgres database?

The dev role is non-superuser and lacks CREATE DATABASE. Schema isolation gives us the same isolation guarantee (test tables live in their own namespace) without requiring a privilege bump.

Setup

  1. Copy .env.test.example.env.test:

    cp .env.test.example .env.test
    

    Adjust TEST_DATABASE_URL / TEST_VALKEY_URL if your dev DB is elsewhere.

  2. (Optional) Verify connectivity:

    node -e "import('postgres').then(({default:p})=>{const s=p(process.env.TEST_DATABASE_URL);s\`SELECT 1\`.then(console.log).finally(()=>s.end())})" 
    
  3. The halobestie_test schema and all test tables are created automatically the first time npm test runs (idempotent — re-running npm test is safe).

Running

npm test              # one-shot run
npm run test:watch    # re-run on file change
npm run test:coverage # plus coverage report under coverage/

Required environment variables

Var Default Purpose
TEST_DATABASE_URL postgresql://halobestie_clone:halobestie_clone@omv.sjamsani.id:5432/halobestie_clone Same as dev — schema isolates
TEST_DB_SCHEMA halobestie_test Schema name for test tables. Hard-rejected if set to public
TEST_VALKEY_URL redis://omv.sjamsani.id:6379/1 Note the /1 — separate logical db from dev
AUTH_JWT_SECRET (must be ≥ 32 chars) Signs JWTs the prod authenticate plugin verifies. Test value can differ from dev
ACCESS_TOKEN_TTL_SECONDS 3600 Optional
REFRESH_TOKEN_TTL_DAYS 30 Optional
CC_ORIGIN http://localhost:5173 Required by the internal app's CORS config

Adding a new test

Templates by type:

Test type Template Sample
Pure service uses db() + fixtures test/services/payment.service.test.js
Service with mocked WS/FCM vi.mock('../../src/plugins/websocket.js') at top test/services/pairing.service.test.js
Route (HTTP-free via inject) app.inject({ method, url, headers, payload }) test/routes/client.payment.routes.test.js

Helpers (under test/helpers/):

  • db.jsdb() returns the shared sql client; resetDb() truncates Phase 3.7 + dependent tables; resetAppConfig() restores config defaults.
  • valkey.jsgetTestValkey() for direct keyspace assertions; flushTestDb() to wipe between tests.
  • server.jsbuildPublic() / buildInternal() for route tests.
  • jwt.jscustomerJwt(id), mitraJwt(id), ccJwt(id) mint tokens the prod authenticate plugin accepts. authHeader(token) builds the header.
  • fixtures.jscreateCustomer(), createMitra({ isOnline }).

Patterns to follow (from the sample tests):

  • Always import status / cause values from ../../src/constants.js — never hard-code 'pending', 'all_mitras_rejected', etc. (See project memory: "Use Enums for Fixed Values".)
  • Mock ../../src/plugins/websocket.js and ../../src/services/notification.service.js for any test that touches pairing / extension / closure — they fan out via WS + FCM and you don't want either to fire on a real socket / Firebase project.
  • Call resetDb() in beforeEach, resetAppConfig() once in beforeAll (or in afterEach if your test mutates config).

Isolation notes

Tests run sequentially (fileParallelism: false, sequence.concurrent: false) because they share one DB schema and one Valkey db. If you ever need parallelism: switch to per-test transactions (BEGIN in beforeEach, ROLLBACK in afterEach) or per-test schemas (CREATE SCHEMA test_${random}) and update vitest.config.js.

Switching to local Docker

If you'd rather run an isolated, throwaway Postgres + Valkey on your machine:

docker compose -f docker-compose.test.yml up -d
# In .env.test:
TEST_DATABASE_URL=postgresql://test:test@localhost:55432/halobestie_test
TEST_DB_SCHEMA=public
TEST_VALKEY_URL=redis://localhost:56379/0

npm test
docker compose -f docker-compose.test.yml down -v

The non-default ports (55432, 56379) avoid clashing with any local Postgres / Redis you have running. Note TEST_DB_SCHEMA=public is OK in the Docker case because the whole database is throwaway — schema isolation is only required when sharing with the dev DB.

Safety guards

  • setup.js hard-fails if TEST_DB_SCHEMA === 'public' AND TEST_DATABASE_URL looks like the dev DB. (Schema reuse on the dev DB would clobber dev tables.)
  • setup.js hard-fails if any required env var is missing — silent fallback to dev URLs would be catastrophic.
  • The migration runs as a child process (not in-process) so its sql.end() at the bottom doesn't tear down the singleton this test process shares with services.