Ramadhan Sjamsani
ad02ee252d
§1 notif banner: permission_handler v11 returns granted unconditionally
for Permission.notification on Android <13 because POST_NOTIFICATIONS
didn't exist as a runtime permission. Result: SHome1st amber "notifikasi
off" banner never showed on API 24-32 even when the user toggled
notifications off in Settings → Apps. Add a
NotificationManagerCompat.areNotificationsEnabled() pre-check via
flutter_local_notifications (works from API 19+) so the banner reflects
the real OS state on older Android.
§5 chat delivery: the contract is "WS when foreground, FCM when
background", but the previous build only honoured (1) — Android keeps
the TCP socket alive after the Dart isolate is paused, so backend's
`socket.readyState === 1` check returned true and FCM never fired.
Fix has five parts (all required together):
1. Customer-side lifecycle observer in client_app/main.dart closes
chatProvider's WS on paused/detached, reconnects on resumed.
2. `_appPaused` gate in main.dart suppresses the activeSessionProvider
listener's auto-reconnect (15s poll in active_session_notifier
would otherwise re-open the WS the next tick after the observer
closed it — defeating the fallback).
3. Mitra-side lifecycle observer in mitra_app/main.dart stashes
`_pausedChatSessionId`, calls mitraChatProvider.disconnect(), and
re-issues connect(saved) on resumed.
4. MitraChat gains a `_connectedSessionId` field + getter so the
observer in step 3 can read it back across disconnect (disconnect
clears it; the next connect overwrites it).
5. SearchingScreen resets pairingProvider when entering with a new
draft.paymentId — previously it retained PairingActiveData with
the *old* sessionId after a session ended, and the next pairing
flow navigated straight to that completed session showing
"Sesi sudah berakhir".
Backend additions under /internal/_test/* for assertion harness:
inspectSessionWsState + GET /ws-connection-state,
POST /send-chat-message-as-mitra (with delivered_via),
POST /send-chat-message-as-customer (with delivered_via),
POST /send-fcm-chat-message (raw FCM dispatch).
Maestro coverage:
- ts-customer-05-01: mitra → customer message when customer is
backgrounded → delivered_via=fcm.
- ts-customer-05-02: customer → mitra message when mitra is
backgrounded → delivered_via=fcm.
- ts-customer-01-01: §1 notif-denied banner on home. Documented
precondition: mitra must be force-stopped or backgrounded on the
chat screen before 05-02 runs (Maestro can only drive one --udid
per run; mitra-side lifecycle observer end-to-end is deferred).
Helper scripts under client_app/.maestro/scripts/:
inspect_ws_state.js, assert_ws_state.js,
send_chat_message_as_mitra.js, assert_delivered_via.js (takes
SENDER=mitra|customer to route to the matching backend endpoint).
README_section_05.md documents the test plan, helper scripts, and the
deferred mitra-side maestro driving. Both apps tested manually on
API 28 AVDs where FCM delivery is sub-second; API 24 has 5-30 min
heartbeats that make it impractical for FCM-related testing.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
62 lines
2.5 KiB
YAML
62 lines
2.5 KiB
YAML
# ts-customer-01-01 — When OS-level notification permission is denied,
|
|
# SHome1st renders the amber "notifikasi off" banner above the
|
|
# 'aku mau curhat' CTA.
|
|
# Spec ref: requirement/flow_customer.mermaid.md §1 — `NotifCheck → no →
|
|
# HomeBanner` (line 24-26 of the mermaid).
|
|
#
|
|
# Banner widget: home_screen.dart::_NotifDeniedBanner. Gating provider:
|
|
# notifPermissionStatusProvider (core/notifications/notif_permission.dart).
|
|
# The provider reads `permission_handler::Permission.notification.status`
|
|
# which, on Android 13+, reflects the runtime POST_NOTIFICATIONS state and
|
|
# on older Android reflects the app's notification-enabled toggle.
|
|
#
|
|
# Pre-requisite (manual setup):
|
|
# The test only exercises the "denied" branch. Disable notifications for
|
|
# the customer app BEFORE invoking maestro:
|
|
# - Android 13+: maestro's `permissions: { notifications: deny }` below
|
|
# handles this (POST_NOTIFICATIONS is a runtime permission).
|
|
# - Android 7-12 (incl. the API-24 dev AVD): the runtime permission
|
|
# doesn't exist, so the maestro `permissions:` block is a no-op.
|
|
# Instead, toggle Settings → Apps → Halo Bestie → Notifications →
|
|
# Off manually. This sets the system `NotificationManagerCompat`
|
|
# state which the app's `notif_permission.dart::readStatus`
|
|
# pre-check picks up. `clearState: true` below is safe — `pm clear`
|
|
# wipes app data but not the system-level notification toggle.
|
|
# The backend FCM path still fires regardless of this branch (the OS
|
|
# simply suppresses the notification); the banner is the only
|
|
# user-visible signal that they're missing alerts, which is what we
|
|
# assert below.
|
|
appId: com.halobestie.client.client_app
|
|
env:
|
|
TEST_PHONE: "+6281234567890"
|
|
BACKEND_INTERNAL_URL: http://localhost:3001
|
|
---
|
|
- runScript:
|
|
file: ../scripts/reset_phone.js
|
|
env:
|
|
TEST_PHONE: ${TEST_PHONE}
|
|
BACKEND_INTERNAL_URL: ${BACKEND_INTERNAL_URL}
|
|
- launchApp:
|
|
clearState: true
|
|
permissions:
|
|
notifications: deny
|
|
- extendedWaitUntil:
|
|
visible:
|
|
text: "Mulai"
|
|
timeout: 15000
|
|
- tapOn:
|
|
text: "Mulai"
|
|
retryTapIfNoChange: true
|
|
- extendedWaitUntil:
|
|
visible:
|
|
text: "(?s).*aku mau curhat.*"
|
|
timeout: 30000
|
|
|
|
# §1 NotifCheck=no → SHome1st banner. Text is the unique copy from
|
|
# _NotifDeniedBanner; the icon is decorative-only and not part of the
|
|
# a11y label.
|
|
- assertVisible: "(?s).*notifikasi off.*"
|
|
- assertVisible: "(?s).*kelewat chat dari bestie.*"
|
|
- assertVisible: "(?s).*nyalain.*"
|
|
- takeScreenshot: /tmp/notif_banner_design
|