Phase 4 checkpoint: chat-screen perf refactor + retryable blast-failure + repo-wide dispose-ref guardrail
Chat-screen performance (customer + mitra): - Parent screens have zero `ref.watch` — only `ref.listen` for side effects - Body extracted into its own `ConsumerStatefulWidget`; AppBar parts split into narrow `.select` consumers (mode, sensitivity, timer) - Per-second timer ticks routed to dedicated providers (`chatRemainingSecondsProvider` + new `mitraChatRemainingSecondsProvider`) so WS `session_tick` frames don't invalidate the rest of the chat state Dispose-in-ref bug fix: - `home_screen.dart`, `payment_screen.dart`, `mitra_chat_screen.dart` — ref-using cleanup moved from `dispose()` to `deactivate()`. Modern Riverpod invalidates `ref` the moment `dispose()` runs; the resulting silent error corrupts the widget-tree finalize and the next screen appears frozen - `halo_lints` package added at repo root with `no_ref_in_dispose` rule to catch this pattern in CI / IDE analysis - `custom_lint` activated in both apps' `analysis_options.yaml` (was installed but never wired in — also brings `riverpod_lint`'s `avoid_ref_inside_state_dispose` online) - CLAUDE.md Pitfalls section added to client_app + mitra_app Phase 4 §3 retryable blast-failure (Option A): - Backend `expirePairingRequest` + all-rejected use `recordIntermediateFailure` instead of `failPaymentSession` so the payment session stays `confirmed` for re-blast - WS `pairing_failed` payload carries `is_terminal: false` on the retryable paths; client parses the flag and exposes `retryBlast()` - "Coba cari lagi" CTA on S7 Timeout now re-blasts on the same payment - Pairing service test updated to reflect the new semantics Customer waiting-payment screen navigation patch: - `_navigateTerminal` uses `Future.microtask` + `addPostFrameCallback` redundancy after a release-mode bug where polling stopped but `context.go` never fired, leaving the screen visually stuck on "menunggu pembayaran" See requirement/resume-2026-05-15.md for next-day pickup checklist (mitra release rebuild + S21 Ultra install + retest is the gating item). Bundles unrelated in-flight Phase 4 §2.x work that was already on disk (ESP screen removal, USP one-time gate scaffolding, bestie-availability public route, OTP service edits, Maestro flow tweaks) — kept together to avoid a partial-rebase mess. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -527,16 +527,26 @@ export const declinePairingRequest = async (sessionId, mitraId) => {
|
||||
pairingTimeouts.delete(sessionId)
|
||||
}
|
||||
|
||||
// Intermediate failure: payment stays confirmed so the customer can re-blast
|
||||
// from the S7 timeout CTA. Audit row is still written.
|
||||
if (session.payment_session_id) {
|
||||
await failPaymentSession(session.payment_session_id, PairingFailureCause.ALL_MITRAS_REJECTED)
|
||||
const paySession = await getPaymentSession(session.payment_session_id)
|
||||
if (paySession) {
|
||||
await recordIntermediateFailure({
|
||||
paymentSessionId: session.payment_session_id,
|
||||
customerId: session.customer_id,
|
||||
causeTag: PairingFailureCause.ALL_MITRAS_REJECTED,
|
||||
amount: paySession.amount,
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
// Terminal: customer is in a searching state and the search just ended with no chat.
|
||||
await notifyCustomer(session.customer_id, {
|
||||
type: WsMessage.PAIRING_FAILED,
|
||||
session_id: sessionId,
|
||||
payment_session_id: session.payment_session_id,
|
||||
cause_tag: PairingFailureCause.ALL_MITRAS_REJECTED,
|
||||
is_terminal: false,
|
||||
})
|
||||
}
|
||||
}
|
||||
@@ -686,19 +696,27 @@ export const expirePairingRequest = async (sessionId, causeTag = PairingFailureC
|
||||
WHERE session_id = ${sessionId} AND response IS NULL
|
||||
`
|
||||
|
||||
// Fail the payment session (if any) — terminal.
|
||||
// Intermediate failure: payment session stays `confirmed` so the customer can
|
||||
// re-blast on the same payment from the S7 timeout CTA. Audit row is still
|
||||
// written so the failed-pairing CC view captures every attempt.
|
||||
if (session.payment_session_id) {
|
||||
await failPaymentSession(session.payment_session_id, causeTag)
|
||||
const paySession = await getPaymentSession(session.payment_session_id)
|
||||
if (paySession) {
|
||||
await recordIntermediateFailure({
|
||||
paymentSessionId: session.payment_session_id,
|
||||
customerId: session.customer_id,
|
||||
causeTag,
|
||||
amount: paySession.amount,
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
// Notify customer via WebSocket (FCM fallback). Terminal pairing failure → PAIRING_FAILED
|
||||
// so the client can route to the failed-pairing screen consistently with the other
|
||||
// terminal paths (cancel / all-rejected / payment-expired-mid-search).
|
||||
await notifyCustomer(session.customer_id, {
|
||||
type: WsMessage.PAIRING_FAILED,
|
||||
session_id: sessionId,
|
||||
payment_session_id: session.payment_session_id,
|
||||
cause_tag: causeTag,
|
||||
is_terminal: false,
|
||||
})
|
||||
|
||||
// Notify mitras to dismiss (request expired) — independent fan-out, run in parallel.
|
||||
|
||||
Reference in New Issue
Block a user